-
Notifications
You must be signed in to change notification settings - Fork 112
Export the Serializable type from the package.
#78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Makes sense but I wonder if we want to change the name to After all pass-by-reference types aren't really serialized. |
|
(Sorry for taking so long to look at this -- had a busy month.) |
|
I agree, |
|
I've updated the PR to change the name to |
|
Thanks, I'd love to merge this but it looks like there's now a conflict, can you resolve? |
`RpcCompatible` and exports it. This is needed to aide integration with other libraries. For instance, if you want to make a generic function that will make use of an RpcStub, you will need to declare a constraint of `RpcCompatible<T>`, but you currently can't because RpcCompatible isn't exported. The woraround is to copy the entire type definition and declare it locally, which works, but this is much simpler.
🦋 Changeset detectedLatest commit: 35837ba The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
I have read the CLA Document and I hereby sign the CLA 1 out of 2 committers have signed the CLA. |
|
I have read the CLA Document and I hereby sign the CLA |
|
I've rebased this on top of latest main branch |
commit: |
This is needed to aide integration with other libraries. For instance, if you want to make a generic function that will make use of an RpcStub, you will need to declare a constraint of
Serializable<T>, but you currently can't because Serializable isn't exported.The woraround is to copy the entire type definition and declare it locally, which works, but this is much simpler.